search

Guekka / bethutil

Common utilities for working with bethesda assets (dds, nif, bsa, hkx...)
https://guekka.github.io/bethutil/
Mozilla Public License 2.0
4 stars 1 forks source link

feat(tex): add option to ignore files by regex #51

Closed mklokocka closed 1 month ago

mklokocka commented 2 months ago

Add a setting to texture Settings that enables ignoring certain file paths completely based on regexes.

Ignore interface and LOD textures for FNV by default, rest of game presets left untouched.

A similar thing could definitely be accomplished by CAO patterns. That however would require tying settings from bethutils with patterns with CAO, which with their current state I am not fully comfortable doing.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (57a7574) to head (844c009).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Guekka/bethutil/pull/51/graphs/tree.svg?width=650&height=150&src=pr&token=llth93S2Em&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar)](https://app.codecov.io/gh/Guekka/bethutil/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== + Coverage 80.40% 80.44% +0.04% ========================================== Files 38 38 Lines 1694 1703 +9 ========================================== + Hits 1362 1370 +8 - Misses 332 333 +1 ``` | [Files](https://app.codecov.io/gh/Guekka/bethutil/pull/51?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) | Coverage Δ | | |---|---|---| | [src/tex/optimize.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/51?src=pr&el=tree&filepath=src%2Ftex%2Foptimize.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL3RleC9vcHRpbWl6ZS5jcHA=) | `73.68% <70.00%> (+1.10%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/Guekka/bethutil/pull/51?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/Guekka/bethutil/pull/51?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Last update [57a7574...844c009](https://app.codecov.io/gh/Guekka/bethutil/pull/51?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar).
Guekka commented 1 month ago

@mklokocka If we're starting to use regex, we might as well bring CAO's Pattern to bethutil, what do you think?

mklokocka commented 1 month ago

Instead I think we should scrap this and make this the responsibility of CAO to provide a good default config (as we discussed on Discord).