Guekka / bethutil

Common utilities for working with bethesda assets (dds, nif, bsa, hkx...)
https://guekka.github.io/bethutil/
Mozilla Public License 2.0
4 stars 1 forks source link

feat(bsa): improve dummy plugin generation #53

Closed mklokocka closed 1 month ago

mklokocka commented 1 month ago

Even though Skyrim supposedly only supports up to two archives (<plugin>.bsa and <plugin> - Textures.bsa), other games like FNV can load an unlimited number of archives attached to the same plugin.

Leveraging this fact is especially important due to the tight plugin limit of the older games.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (81484ab) to head (ee85d9a). Report is 1 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Guekka/bethutil/pull/53/graphs/tree.svg?width=650&height=150&src=pr&token=llth93S2Em&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar)](https://app.codecov.io/gh/Guekka/bethutil/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) ```diff @@ Coverage Diff @@ ## dev #53 +/- ## ========================================== + Coverage 80.40% 80.45% +0.05% ========================================== Files 38 38 Lines 1694 1709 +15 ========================================== + Hits 1362 1375 +13 - Misses 332 334 +2 ``` | [Files](https://app.codecov.io/gh/Guekka/bethutil/pull/53?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) | Coverage Δ | | |---|---|---| | [include/btu/bsa/settings.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/53?src=pr&el=tree&filepath=include%2Fbtu%2Fbsa%2Fsettings.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvYnNhL3NldHRpbmdzLmhwcA==) | `87.40% <100.00%> (+0.18%)` | :arrow_up: | | [src/bsa/plugin.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/53?src=pr&el=tree&filepath=src%2Fbsa%2Fplugin.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL2JzYS9wbHVnaW4uY3Bw) | `77.66% <93.33%> (+1.00%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/Guekka/bethutil/pull/53?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/Guekka/bethutil/pull/53?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Last update [c42605d...ee85d9a](https://app.codecov.io/gh/Guekka/bethutil/pull/53?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar).
mklokocka commented 1 month ago

Please target dev, not main

Will do.

I've noticed your formatting is not always the same as mine. What version of clang format do you use?

I'm on Windows + Visual Studio 2022 for this, so I have been using its formatting which should call clang format. 🤔

I've pushed a commit to your branch, does it look good to you?

Yep, merging it in.

Guekka commented 1 month ago

Thank you @mklokocka. By the way, forget about what I said related to dev branch, I don't mind if you target main