Closed mklokocka closed 1 month ago
Attention: Patch coverage is 97.22222%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 80.45%. Comparing base (
81484ab
) to head (ee85d9a
). Report is 1 commits behind head on dev.
Please target dev, not main
Will do.
I've noticed your formatting is not always the same as mine. What version of clang format do you use?
I'm on Windows + Visual Studio 2022 for this, so I have been using its formatting which should call clang format
. 🤔
I've pushed a commit to your branch, does it look good to you?
Yep, merging it in.
Thank you @mklokocka. By the way, forget about what I said related to dev branch, I don't mind if you target main
Even though Skyrim supposedly only supports up to two archives (
<plugin>.bsa
and<plugin> - Textures.bsa
), other games like FNV can load an unlimited number of archives attached to the same plugin.Leveraging this fact is especially important due to the tight plugin limit of the older games.