search

GuerillaStudio / vanillalist

Handpicked Vanilla JavaScript Plugins Repository
https://vanillalist.top
Other
118 stars 11 forks source link

152-swiffyslider #43

Closed nicped closed 1 year ago

nicped commented 1 year ago

Adding Swiffy Slider and Carousel to vanilla list

netlify[bot] commented 1 year ago

Deploy Preview for vanillalist ready!

Name Link
Latest commit daeacf5c480b2631de96c5a283214484650306c9
Latest deploy log https://app.netlify.com/sites/vanillalist/deploys/63faca551625bc000852d3d5
Deploy Preview https://deploy-preview-43--vanillalist.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

TixieSalander commented 1 year ago

Hi, thanks for the submit!

I have a few questions before going furthermore through the PR:

  1. Knowing the thumbnail won't stay animated: do you wanna keep it this one?
  2. The current thumb doesn't match the 308x195 ratio so hide some interesting part of the plugin's UI (navigation buttons for example). No biggie but same question than previous point.
  3. Are you willing to replace all pictures of women in bikini used in every examples of your plugin by something else not objectifying?

Best regards

nicped commented 1 year ago

Thank you for the review. I have updated the image in the pull request to follow the ratio. Also updated the example site to not use the mentioned image.

TixieSalander commented 1 year ago

Merged!

I made some wording adaptions to optimize search and clarity of the benefits your plugin bring as well than avoiding get target as duplicated content by crawlers for having very similar text than your own website.

Thanks again for your contribution!

nicped commented 1 year ago

Thanks!