search

Guerra24 / Firefox-UWP-Style

Sun Valley + MDL2 Theme for Firefox
MIT License
399 stars 9 forks source link

UI Improvements #44

Open ghost opened 2 years ago

ghost commented 2 years ago

After examining this userChrome, I can confidently say it is one of the best ways to merge Firefox with the Windows UI (especially Windows 11). But I've seen some inconsistencies, as given below.

1) The toolbar is too compact for me. I like to use the Normal mode, despite of what people say about the Proton redesign. 2) Ability to use custom themes is missing! 3) Tabs should be more rounded, like Microsoft Edge, or the default Proton tabs would look good enough. 4) The hamburger menu is shifted (a little bit) to the left. This makes no sense, and I guess it's a bug. (See attachment for reference.) image 5) Some buttons bigger than expected. image image

Looking forward to the development of this project!

Guerra24 commented 2 years ago
  1. This is expected, since compact theme was hidden behind a pref the normal mode was converted into the compact mode.
  2. This is expected too. I can check if it could be fixed.
  3. Exist in WIP form by creating another bool pref uwp.sun-valley.round-tabs, it was not kept as default since it has some issues.
  4. This is due to the shadows. It can be reduced but not removed entirely, I'll look into it.
  5. I'm aware some parts looks kinda unfinished, I haven't had time to work more on it unfortunately.
ghost commented 2 years ago

Please take your time. I'm looking forward to newer updates. Thanks for the fast responses.

Guerra24 commented 2 years ago

Margin reduced a bit. This is gonna need a bit of tweaking down the road due to it being different in both styles. image

Download buttons should look way better now. firefox_2022-03-25_02-26-55

ghost commented 2 years ago

Thank you! Download buttons look perfect.

ghost commented 2 years ago

image Just here to say, thank you for the new improvements. That slight border around the tab is a great improvement! I no longer get confused between the active and inactive tabs like I used to before :P The hamburger menu looks way better now too...