Guerra24 / Firefox-UWP-Style

Sun Valley + MDL2 Theme for Firefox
MIT License
406 stars 9 forks source link

Context menu rendering issues (black box around context menus) #51

Closed dr-baba closed 2 years ago

dr-baba commented 2 years ago

There is a black box around all context menus when I right click anywhere (on the menu bar, bookmarks bar or the content).

image image

However this is not present when opening (left clicking) the application menu/overflow menu on the top right.

I'm using Firefox beta v100 on Windows 11 beta build 22598.100. I am using the sunvalley theme with mica.

I have tried toggling gfx.webrender.dcomp-win.enabled and layout.css.backdrop-filter.enabled to no avail.

Also acrylic does not seem to be working anywhere with/out layout.css.backdrop-filter.enabled but mica is working fine.

I might also add there is a white bar at the bottom of the history popup (which goes away after resizing the window). image

This theme is perfect except that issue, any fixes? Thanks

Guerra24 commented 2 years ago

That's new, I'm running stable Win11 and the only issue I have seen is the white bar but that can be fixed by disabling gfx.webrender.dcomp-win.enabled and restarting Firefox.

What happens if you go into css/context.css and add border-radius: 0px !important; in the menupopup selector? Restart Firefox afterwards. image

Acrylic is disabled because backdrop-filter is not working, I'm waiting for 1749625 which should land in nightly next week.

I don't have an insider vm on hand but if the issue continues I could setup one.

dr-baba commented 2 years ago

That didn't work unfortunately.

But I tried installing this theme on firefox in a Windows 11(dev) VM and it seems to not have this issue. I'm not sure, maybe it's something corrupt, might have to reinstall firefox?

Guerra24 commented 2 years ago

I see... I'm gonna setup a vm and test it there.

I would suggest creating a new firefox profile and trying it there too, just in case it might be a configuration issue. Aside from that idk until I can reproduce it.

Guerra24 commented 2 years ago

Works fine here. It could be a configuration issue in the profile.

image image

dr-baba commented 2 years ago

I have created a new profile and reinstalled the theme and it seems to have fixed it, thanks for your help.

Another thing I noticed is the bottom of text cutting of in the search bar. image

dr-baba commented 2 years ago

@Guerra24 any fixes for the text cutting off? Or is it just on my end?

Guerra24 commented 2 years ago

It's on my end too. Don't worry, I just haven't had any time to work on this. image