Guerra24 / LRReader

A feature-complete reader and client for LANraragi
GNU General Public License v3.0
88 stars 5 forks source link

Longstrip scrolling and WS movement #23

Closed hollywings closed 2 years ago

hollywings commented 2 years ago

I love the reader but I would like to see 2 features added, for convenience of course. Can you add a long strip format where you can scroll down and see pages stacked vertically without abruptly snapping to the next page? Also I would love to use W and S for up and down scrolling for situations where I cannot use my right hand. Also, a continuous scrolling mode where if you hold down W/S or Up/Down it will keep scrolling. Thank you very much.

Guerra24 commented 2 years ago

Hello. Now WASD also work for movement and made holding down arrow up/down or W/S keep scrolling the page.

I'll look into the vertical reader but looks doable.

Guerra24 commented 2 years ago

Alright gave it a shot and this is the result. It's available in the latest nightly.

https://user-images.githubusercontent.com/9023392/146498780-26e4a3d3-a628-4af3-b93d-162f6ab20b5d.mp4

And those are the issues.

I have two options for fixing most of those issues.

  1. Lock the pages size to some standard value.
  2. Get rid of all optimizations and load all pages at once (which can be quite heavy with high res archives).

Thoughts on this? otherwise I will go with option 2. (Yes, I can make it so you can choose one of those options but I would like to avoid this)

Also posted the same in LANraragi's Discord.

hollywings commented 2 years ago

Looks to me like option #2 is a reasonable tradeoff, let's see if it works out ok

Guerra24 commented 2 years ago

Alright I think that's it. Went with a hybrid approach instead.

It will pull all pages and calculate the size of the largest one and then force scale any smaller pages.

The final implementation of the vertical reader is available in nightly if you want to give it a try. I'll close this once v1.7.4 is out.

Guerra24 commented 2 years ago

v1.7.4 is now out with those changes!