search

Guestlogix / traveler-ios

4 stars 3 forks source link

Check availability: starting price is zero #38

Open vbereg opened 5 years ago

vbereg commented 5 years ago

Reproduction steps:

  1. open app on home page
  2. click on experience (New York from Baltimore by Rail One day trip)

Actual result: Starting at is listed at 0.

Expected result: We should have it at the price of 1 adult ticket (general admission).

Found on build 0.2 from Dec 13

blocks #8

ata-n commented 5 years ago

This is displaying what currently is being passed as the priceStartingAt attribute. I imagine SimpleNights data is just like this.

@godd9170 Can you check if the service is properly forwarding this value?

vbereg commented 5 years ago

Vera will check latest build and if it can be closed.

rayojosiah commented 5 years ago

@ata-n @vbereg i would close this i checked the api and we are getting 0 back for atleast all the products i checked.

vbereg commented 5 years ago

@rayojosiah is that the SimpleNight API or our API that is sending zeros (not passing prices from SimpleNight) to mobile?

rayojosiah commented 5 years ago

@vbereg Simplenight

On Sun, Feb 24, 2019 at 10:48 PM vbereg notifications@github.com wrote:

@rayojosiah https://github.com/rayojosiah is that the SimpleNight API or our API that is sending zeros (not passing prices from SimpleNight) to mobile?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Guestlogix/traveler-ios/issues/38#issuecomment-466862419, or mute the thread https://github.com/notifications/unsubscribe-auth/AIEwd9OlMDttW6EGoSiM8kU4Tq72SP88ks5vQ10ggaJpZM4ZT1_5 .

vbereg commented 5 years ago

@rayojosiah hmm if we always have zeros (at least from SimpleNight) it doesn't make sense to show it. I'll put it as an ask for SimpleNight to pass this in their API. Also assuming other 3rd party content providers will be able to provide starting ticket prices. I'll keep this ticket in the pm column until we hear back from SimpleNight.

Justin-Lag commented 5 years ago

Moving to Inbox. We're going ahead with Livn at the moment. This can be a future consideration when SimpleNight becomes in scope again.