Gugli / KeeLocker

KeePass2 plugin to open BitLocker volumes
Do What The F*ck You Want To Public License
13 stars 0 forks source link

Not working or not using correctly #2

Open vertigo220 opened 2 years ago

vertigo220 commented 2 years ago

I don't know how exactly this is supposed to work since there's no documentation, but when I click "Fill drive GUID" it says "Unable to get GUID." I've tried entering the drive letter first, I've tried finding the GUID manually and entering that in there, but nothing makes this plugin work.

Gugli commented 2 years ago

Hello,

If you have a static drive (let's say a HDD bound to "D:") encrypted with bitlocker, you should :

You can the either tick the checkbox "Unlock volume on opening" that will do so when the Database is opened (but that requires to close then open the DB). Or you can click "Unlock Volume" to test it right now.

If it is still not working : what flavor/version of windows are you using ?

Gugli commented 2 years ago

Note : the Drive GUID feature is for more complex scenarios. Eg : you use the same DB on multiple machines, along with a USB stick cyphered using BitLocker. The issue is that on the first machine, you USB stick mounts as "D:", but on another one, it mounts as "E:". In such cases, the "Drive Mountpoint" is not super useful, so instead of using it, you can use the "GUID", that should work in such scenarios.

vertigo220 commented 2 years ago

Yeah, I understand the purpose of GUID, and that's why I'm trying to use it, but I have no idea how. It doesn't autofill it (which is what it looks like it would do when clicking the button) and entering it manually doesn't work.

Gugli commented 2 years ago

What flavor/version of windows are you using ?

vertigo220 commented 2 years ago

Sorry. Win10x64 Pro 21H1 build 19043.1415

Gugli commented 2 years ago

I've been testing on my end, with a very similar OS (Windows 10 Pro x64 21H1 build 19043.1706 ). I created a USB stick :

When I choose the current drive mountpoint of a USB stick, and click "Fill drive GUID", it works. Unlocking also works.

The GUID should look something like : \\?\Volume{123456ab-1234-1234-1234-123456789abc}\

Do you see anything that could make a significant difference ?

vertigo220 commented 2 years ago

Ok, that works, but the UI is very confusing and there are no instructions. The use of radio buttons suggests one or the other (which technically it is, but in this case you have to use one then the other, so while you're only using one in the end, you're still using both), so I didn't realize I had to select the drive in the top box then hit the button, the location of which directly under the bottom box makes it look like it's meant to be used with that box. I'd suggest a couple changes to make it more clear how to use it:

Unrelated, but, if possible, I'd also suggest having the drive dropdown show all drives, as it only shows A-H, and not all users may know they can simply type additional letters in.

Gugli commented 2 years ago

I've tried to improve the UI in v1.3 based on your suggestions. I have also renamed the button to "Convert to GUID", and it is now disabled unless in "mountpoint" mode. I believe it's now clearer and does not need explicit instructions.

I'd love your feedback though. Thanks

vertigo220 commented 2 years ago

It looks better, at least from what I can recall. I should have looked again at the old layout before updating, but this does seem to make at least more sense. That said, I already know how it works now, so I can't look at it with fresh eyes, and while maybe not necessary, there are still a few things that could be done to make it easier:

Gugli commented 1 year ago

I think there are valid use-cases that are incompatible with the changes you are suggesting.

That said :

Do you think this would make a significant improvement ?

vertigo220 commented 1 year ago

Fair enough on the first point.

For the second, I definitely understand the potential for issues, but I don't think if they just put a single letter or a letter and a colon (e.g. F or F:) that converting it to e.g. F:\ would be an issue, and if they needed a network drive or some other non-standard-mounted drive they would use something different, which wouldn't be converted. I want to be clear that I personally had/have no trouble with the current setup for this, I just know how easily more basic users can get confused and try to think of how things can be done to help prevent that, and I can absolutely see somebody putting e.g. "F" or "F:" and not understanding why it's not working.

Whenever I write or make anything that will likely be used by others, I always try to make it as idiot-proof as possible. So in this case, if you're concerned that auto-correcting it might lead to issues, you may consider just doing basic input checking, to see if what they entered is valid. It very well may not be necessary, but you just never know. If you choose to leave it how it is, I certainly won't be bothered by that, I'm just trying to offer some thoughts on how to help ensure less knowledgeable users don't struggle.

The ellipses would probably help those users realize they can add any drive letter, and hopefully they would realize to do it in the same format as the ones already present in the dropdown, so there's a good chance that would be enough for most (and it could be argued anyone that can't figure that out probably shouldn't be messing with something like this). I definitely think the additional text could prove helpful to new users.

Gugli commented 1 year ago

I have been trying some improvements. image

I will still have some ideas, but this is where I'm heading.

Gugli commented 1 year ago

And the window look like that when the combobox is collapsed image