Guibod / mightstone

A python library to handle all sort of Magic The Gathering related stuffs
MIT License
0 stars 0 forks source link

Mongita (temporary) fork prevents releases on pypi #34

Closed Guibod closed 3 months ago

Guibod commented 1 year ago

Python semantic release fails to push any new release to pypi due to some limitations. In this build for instance we cannot push mightstone 0.6.1 to pypi:

400 Invalid value for requires_dist. Error: Can't have direct dependency: 'mongita @ git+https://github.com/Guibod/mongita.git@feat-binary-ids-mongo4'

We need to correct this since beanie / mongita support is an important core feature of Mightstone

Guibod commented 1 year ago

This is discussed at Poetry level in this thread

I don't think we'll ever overload the way Poetry defines Git dependencies to allow for the implicit vendoring requested in this issue -- instead, submodules and https://github.com/python-poetry/poetry/issues/4583 are the best way to achieve this, in a way that is more explicit and flexible.

So I think we are stuck with https://github.com/python-poetry/poetry/issues/4583, that does not seems to be actively developed.