Guichaguri / BetterFps

Performance Improvements
GNU Lesser General Public License v2.1
99 stars 22 forks source link

Taylor's Math FIX (TESTED SOLUTION) #162

Open TehMartinXz opened 1 year ago

TehMartinXz commented 1 year ago

For the two people that see this in the future, @Elephant1214 updated BetterFPS' code, fixing Taylor's Algorithm in the process (I believe they haven't said anything publicly, hence why I'm the one posting this).

Even though for me, Taylor's isn't the fastest algorithm (According to BetterFPS automatic benchmark), I've tried the fixed jarfile and it seems to be working perfectly fine. I'm aware that most people don't know how to compile the mod by themselves, so here I've uploaded a .zip file that contains the mod with Elephant1214's fix (If you do know how to compile the mod, I'd suggest you compile it by yourself for the sake of not trusting files from random people on the internet - for the rest, I guess you'll have to trust me lol).

Gonna assume that Guichaguri won't update the mod, so I hope that this will be helpful for someone.

BetterFPS-1.6.0.zip

Btw, the fix is for 1.12.2

Elephant1214 commented 1 year ago

If anyone is looking for versions made for 1.13+, that isn't happening. The algorithms cause odd rendering issues in newer versions and produce virtually no difference in performance because of improvements made to Java and the game itself. If you're looking for better performance in 1.16+, use a Fabric mod pack like Fabulously Optimized or the Forge ports of the mods that FO uses.

dazadazu commented 1 year ago

Thanks for this. I've always disliked betterfps but randomly running into this a day ago was just fate.

Guichaguri commented 1 year ago

Thank you!

I'm not going to update the mod to newer versions, mostly for the reasons @Elephant1214 already mentioned. Updating this mod means completely rewriting it with new optimizations, which makes it a completely new mod, just like other optimization mods out there. There's probably nothing from this mod that can be reused.

I might release a "final update" for all versions from 1.7.10 up to 1.12, including contributions like this one and a few other fixes too, just for the legacy sake... maybe

Roadhog360 commented 1 year ago

That'd be appreciated. Right now I completely discourage its use due to multiple issues, as well as saves being soft-bricked with Elytra backports on 1.7.10 (also happens with Backlytra) If the algorithms were thoroughly tested and fixed I would rescind my current advice to not use BetterFPS in 1.7.10 as well as undo the code in my mod that locks functionality for safety reasons. Otherwise if you no longer plan on updating this, I would recommend adding a warning on the mod page that BetterFPS can't be considered safe.

JL2210 commented 1 year ago

Kudos to you for providing the jar file! Was really not looking forward to dealing with gradle again.

MrRedstoneA1 commented 3 months ago

Please do release final updates for older versions. Especially 1.12.2 even though it is abandoned, it still has a very active modding community. Also I did scan the fixed jar file and found no malware, it's safe.