GuidanceOfGrace / CLASSIC-Fallout4

Crash Log Auto-Scanner & Setup Integrity Checker for Fallout 4 / Buffout 4. Tool that extensively scans Fallout 4 game & mod files and Buffout 4 crash logs, then provides troubleshooting advice depending on what it finds.
8 stars 4 forks source link

Not-so-small things #58

Closed evildarkarchon closed 1 year ago

evildarkarchon commented 1 year ago

This PR does NOT contain the changes in PR #57 The regex pattern is to parse the results of the plugin/formid/result xedit script. Nothing is implemented with it yet, but it's there when needed. Also, one step towards Skyrim, an exe hash generator tool script.

evildarkarchon commented 1 year ago

I am pulling PR #57 in since this PR now modifies the same file and needs the same pattern fix.

evildarkarchon commented 1 year ago

From what I can tell, the stats checkbox is vestigial. So, for now, I'm force-disabling it to indicate that it doesn't actually do anything. Github Copilot wanted to make it invisible, but I tried it and it made the window not look right. It would probably require shuffling the other checkboxes around to totally get rid of that check box.

evildarkarchon commented 1 year ago

The duplicate label was able to stay hidden because they had identical placement and font size/boldness

evildarkarchon commented 1 year ago

In my proposal for getting rid of the vistigial stats checkmark, I moved IMI mode into its place and changed the label to fit.

evildarkarchon commented 1 year ago

Since Fudgyduff seems to be getting back into the swing of things in regards to updating Buffout 4, I felt the need to add an alternative to pushing a new build just to update the current supported versions. It's a simple json file that has the same values as the old hard-coded values (which are still there as a fallback). I kept the inital implementation extremely simple, no config checks or terminal output. I also added a script that, in the fashon of my culprits json script, allow you to modify the dictionary in the file and then run it to create a new json file.

evildarkarchon commented 1 year ago

Correction for the latest commit: it was 2 times, but it's best to avoid compiling the same regular expression more than once anyways. Which is why I try to avoid regx.search (representing both standard re module and the regex pip module).

evildarkarchon commented 1 year ago

Recent versions of Buffout 4 OG remove the leading zeroes for the form-id part of the plugins list. So what used to be [00] is now [ 0]. Same applies to ESL address space, what used to be [FE:000] is now [FE: 0]