search

GuidanceOfGrace / CLASSIC-Fallout4

Crash Log Auto-Scanner & Setup Integrity Checker for Fallout 4 / Buffout 4. Tool that extensively scans Fallout 4 game & mod files and Buffout 4 crash logs, then provides troubleshooting advice depending on what it finds.
8 stars 4 forks source link

Tracker/RFC: My changes to NEW-CLASSIC #64

Closed evildarkarchon closed 1 year ago

evildarkarchon commented 1 year ago

Just poking and prodding with the code, getting familiar with it and making some minor (so far) changes.

evildarkarchon commented 1 year ago

Please leave any comments you might have, I know I went a bit overboard with my previous tracker pull-request. Keeping this as a draft for now.

evildarkarchon commented 1 year ago

VS Code's type checker freaks the fuck out when methods are used on anything that has even the remotest possibility of returning None (even if it is almost impossible to trigger a None return). Only options are to use conditionals to appease it or add the # type: ignore. I hate ignoring sections of code in case of legitimate issues, but my hand feels force here.