GuidoBartoli / sherloq

An open-source digital image forensic toolset
GNU General Public License v3.0
2.67k stars 250 forks source link

Bugs in Windows #55

Closed marlonio closed 2 years ago

marlonio commented 2 years ago

Hi Guido, i installed on my windows laptop Sherloq. It was no easy because i crush into the "libmagic issue". At the end i solved installing matplotlib with pip. Now i got a serie of bugs when i click on some tools. First, when i start the software from the terminal i got the "error" that you can see in the image: cattura I'll give you the list of the tools that work and the tools that doesn't work;

  1. File Digest - Doesn't work (in terminal appear an error "magic.MagicException: None") THIS ERROR DOES NOT CRASH THE SW
  2. Hex Editor - Works well
  3. Similiar Search - Works well (Could be nice have Yandex Reverse Image Search on the website list..)
  4. Header Structure - Doesn't work (it's requested the "Enter" pressing inside the terminal, after you did it a windows in SW appear but with "impossible reach the website" info) THIS ERROR DOES NOT CRASH THE SW
  5. EXIF Full Dump - Works well
  6. Thumbnail Analysis - Works well (But it's requested the "Enter" pressing inside the terminal windows"
  7. Geolocation Data - Not tested with geolocated picture, but seems to work
  8. Enhancing Magnifier - Works well
  9. Cannel Histogram - Works well
  10. Global Adjustments - Works well
  11. Reference Comparison - Works well
  12. Luminance Gradient - Works well
  13. Echo Edge Filter - Works well
  14. Wavelet Treshold - Works well
  15. Frequency Split - Works well
  16. PCA Projection - Works well
  17. Pixel Statitics - Works well
  18. Noise Separation - Works well
  19. MinMax Deviation - Works well
  20. BitPlane Values - Works well
  21. PRNU Identification - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  22. Quality Esimation - Doesnt Work THIS ERROR CRASH THE SW (No info appear in terminal windows)
  23. Error Level Analysis - Works well
  24. Multiple Compression - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  25. Jpeg Ghost Map - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  26. Contrast Enhancement - Works well
  27. CopyMove Forgery - Works well
  28. Composite Splicing - Works well
  29. Image Resampling - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  30. Median Filtering - Works well
  31. Illuminant Map - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  32. DeadHot Pixels - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  33. Stereogram Decoder - Works well

I'm really interested in the software, I have not particular computer skills, but if you need i could help you as a tester. Thanks for your work and trust me, is really interesting and if you improve it you could get big satisfaction from it

GuidoBartoli commented 2 years ago

Hi @marlonio, thanks for reporting this, I will try to address every item.

Hi Guido, i installed on my windows laptop Sherloq. It was no easy because i crush into the "libmagic issue". At the end i solved installing matplotlib with pip. Now i got a serie of bugs when i click on some tools. First, when i start the software from the terminal i got the "error" that you can see in the image: cattura

These are Tensorflow deprecation warnings coming from my adaptation of NoisePrint code to work under TF2 via retro-compatible CNN v1.0 layers. Since they did not update their code since 2020, at the moment there is not much I can do to overcome this (I actually do not have enough time to look into the original NoisePrint code, but a TF2-compatible fork would be very welcome😄).

I'll give you the list of the tools that work and the tools that doesn't work;

  1. File Digest - Doesn't work (in terminal appear an error "magic.MagicException: None") THIS ERROR DOES NOT CRASH THE SW

Already reported in #46.

  1. Similiar Search - Works well (Could be nice have Yandex Reverse Image Search on the website list..)

Ok, noted for later addition, thanks.

  1. Header Structure - Doesn't work (it's requested the "Enter" pressing inside the terminal, after you did it a windows in SW appear but with "impossible reach the website" info) THIS ERROR DOES NOT CRASH THE SW

22 still needs some work from me.

  1. Thumbnail Analysis - Works well (But it's requested the "Enter" pressing inside the terminal windows"

Also related to #22.

  1. PRNU Identification - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  2. Multiple Compression - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  3. Jpeg Ghost Map - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  4. Image Resampling - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  5. Illuminant Map - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW
  6. DeadHot Pixels - Doesnt Work (Nothing Happen when i press it) THIS ERROR DOES NOT CRASH THE SW

As stated here, tools written in italics are planned, but not yet implemented.

  1. Quality Estimation - Doesnt Work THIS ERROR CRASH THE SW (No info appear in terminal windows)

This is strange... really no message at all in the console?

I'm really interested in the software, I have not particular computer skills, but if you need i could help you as a tester. Thanks for your work and trust me, is really interesting and if you improve it you could get big satisfaction from it

I developed and tested under Linux and at the moment I do not have a Windows machine at hand to thoroughly test it, so your testing and bug reporting is much appreciated, many thanks! And even if it's a personal research project, I'm glad you find Sherloq useful!😄

TechiBBB commented 2 years ago

Hi, I updated the Sherloq source code today and cannot confirm these issues. @marlonio : is it possible that your source code is outdated? The Quality Estimation feature is working fine on my side (see below) and the italic menu entries are disabled in my menu, that means nothing happens when I access them (Windows10, Python 3.10.4). QE