Guikingone / SchedulerBundle

Repetitive tasks as a breath in Symfony
MIT License
111 stars 10 forks source link

feat(transport): symfony 6 cache support #280

Closed tacman closed 2 years ago

tacman commented 2 years ago

Seems like this was just an oversight, no particular reason to require version 5 of the cache.

tacman commented 2 years ago

hmm, so I was wrong about being able to use symfony 6 cache, the CacheTransportTest fails.

Alas, I'm not sure if it's a matter of fixing the test, or fixing something in the code. Regardless, not something I can easily do. And low priority, I thought it was just an oversight.

        $pool = $this->createMock(CacheItemPoolInterface::class);
        $pool->expects(self::exactly(3))->method('hasItem')
            ->withConsecutive([self::equalTo('_scheduler_task_list')], [self::equalTo('foo')])
            ->willReturnOnConsecutiveCalls([true], [false], [true])
        ;
Guikingone commented 2 years ago

Hi @tacman 👋🏻

Could you gave more insights about what the differences are in Sf 6 regarding the cache?

Regarding the test, it could be interesting to improve the test rather than keeping the mock by using a valid adapter, WDYT?

tacman commented 2 years ago

Unfortunately, I'm not expert enough in either the cache or writing tests. In fact, I came across this bundle when looking for a bundle with "best practices" to model my bundles on.

On Fri, Jun 10, 2022 at 9:26 AM Guillaume Loulier @.***> wrote:

Hi @tacman https://github.com/tacman 👋🏻

Could you gave more insights about what the differences are in Sf 6 regarding the cache?

Regarding the test, it could be interesting to improve the test rather than keeping the mock by using a valid adapter, WDYT?

— Reply to this email directly, view it on GitHub https://github.com/Guikingone/SchedulerBundle/pull/280#issuecomment-1152359748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQO5AYLEYOOD7I6SSY3VOM7ARANCNFSM5YNRFD7Q . You are receiving this because you were mentioned.Message ID: @.***>

Guikingone commented 2 years ago

Unfortunately, I'm not expert enough in either the cache or writing tests. In fact, I came across this bundle when looking for a bundle with "best practices" to model my bundles on.

If you wish to structure your own bundle, it's a better idea to read the official documentation: https://symfony.com/doc/current/bundles.html 🙂

tacman commented 2 years ago

I've read that, and SymfonyCast's reusable bundles, many times. Still, I struggle. Nonetheless, I published my first Medium article on the topic! @.***/easily-share-your-twig-extensions-with-symfony-6-1-ff633bf7d9db

On Fri, Jun 10, 2022 at 9:51 AM Guillaume Loulier @.***> wrote:

Unfortunately, I'm not expert enough in either the cache or writing tests. In fact, I came across this bundle when looking for a bundle with "best practices" to model my bundles on.

If you wish to structure your own bundle, it's a better idea to read the official documentation: https://symfony.com/doc/current/bundles.html 🙂

— Reply to this email directly, view it on GitHub https://github.com/Guikingone/SchedulerBundle/pull/280#issuecomment-1152386174, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQNB6FZVN3P3TPCA5DDVONB7PANCNFSM5YNRFD7Q . You are receiving this because you were mentioned.Message ID: @.***>

Guikingone commented 2 years ago

Hi @tacman 👋🏻

The support for symfony/cache >= 5.4 is now merged into main, should be released with 0.9.4 pretty soon 🙂