search

GuildCrafts / Trossello

Open Source Trello Clone
MIT License
6 stars 19 forks source link

WIP: Add check to prevent searchbar from activating when focus is in Search Textarea #164

Closed lumodon closed 7 years ago

lumodon commented 7 years ago

Existing issues: Clicking the "x" in search bar will occasionally exit focus but leave text in box. Cannot reproduce consistently (appears to be random!) Clicking on the lower right corner of the search bar, but very very close to search bar, will close focus of search bar yet leave text there. *Code for checking is relying on class-name. What if class name changes later? Can we "get" a ReactDOM token/artifact/entity instead?

lumodon commented 7 years ago

clicking inside the card search bar after text has been typed erases typed text

jaredatron commented 7 years ago

okay wait which PR is which?

lumodon commented 7 years ago

Fixed commit message and removed bloated commits. This PR directly addresses issue raised on trello board. (linked)

Reiteration: What was happening: You type text in search bar, then click on search bar, and text is erased by "closeIfUserClickedElsewhere" Expected: Clicking on search bar should not remove text, because search bar is not "Elsewhere" What happens now: Clicking on search bar will not erase text, but will simply refocus on self (i.e. nothing happens) What's still broken: 1.Clicking very very close to search bar, on lower right corner specifically, will defocus search bar, and leave text filled in.

  1. Occasionally (cannot reliably reproduce; appears random) clicking the "X" to close out of search-bar, will defocus and not remove text.
jaredatron commented 7 years ago

i think this was merged in another PR