Open lizzkats opened 8 years ago
@deonna Since we were talking about this together can you take a look at this for me? :)
@lizzkats - sure! I'll look it over later today.
I think the goal looks good - I would add some additional quality standards: ES2015 syntax, short file lengths (since the current codebase has just one incredibly long file) separation of view code from app logic (since the HTML + SVG and JS logic are all jumbled together).
Can you also include a link to your in progress repo?
Otherwise, I think you can remove this from draft
so you can vote on it.
Description
Gridmapper is an open source simple dungeon map making software written by Alex Schroeder. Currently, the code has a few bugs. Let’s rebuild it and make it better! Original here: https://campaignwiki.org/gridmapper.svg Original repo here: https://github.com/kensanata/gridmapper Bonus: blog of the person who wrote it https://alexschroeder.ch/wiki/Gridmapper
Context
This goal is useful because you get to work from an existing code base and modernize it. You can either rebuild the app, or you can try and improve the existing features.
This goal uses SVG for the map icons, so that's cool. If you're not interested in drawing your own icons with SVG, you can use the SVG code for the icons which is included in the original repo. Here is my in-progress repo where I am currently attempting to separate the files: https://github.com/lizzkats/Gridmapper
Specifications
List of specifications (specs) for the completed goal. These are declarative sentences (statements) describing a feature of the final product.
Stretch Goals
Required
Do not remove these specs - they are required for all goals.
Quality Rubric
What are some appropriate quality objectives for this goal? These are statements about the internal characteristics of the product that demonstrate fine design and craftspersonship, not its external features.
-Code is readable -ES2015 Syntax -Short file lengths -Separate view code from app logic (No mixing frontend and backend) -No bugs -If working from original repo, code is translated to newest versions of HTML, CSS & JS.
This work is licensed under a Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License.
This work is licensed under a Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License.