Open GuilhermeGiachellin opened 3 years ago
Hi dear student,
Good job so far! You still need to work on some issues to go to the next project, but you are almost there!
You used proper GitHub Flow ✔️ Your linter checks are all passing ✔️ Your README and PR message are descriptive ✔️
[x] It looks like the card are assigned to a member, but it's important to consider that for the member should appear the image on the side like the next example (please work on it): 🐶
[x] Students needed to decide who is Student A, Student B, Student C. So each card with Student A in its title should always be assigned to the same student (and analogical for other students). It looks like right now all cards have the same user. I kindly invite you to fix this. 🐱
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thank you very much now, we fixed it.
Hi there,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
The group is composed of two people.
https://github.com/GuilhermeGiachellin/Anime-Capstone/projects/1