Guillaume-Docquier / guillaume-docquier.github.io

MIT License
5 stars 7 forks source link

Improve search performance #39

Closed pablolazaro closed 3 years ago

pablolazaro commented 3 years ago

Hey @Guillaume-Docquier. First I would like to let you know how much I appreciate all the work you've done with the website. Is an incredible tool and is going to help a lot to the Crowfall community. Yesterday I've found the site and one thing that I realized is the text search was a bit slowly (like it had some kind of stuttering due to layout shifts between key strokes). I'm not a very experienced React developer but I tought that maybe I could bring something to the table.

Basically the idea is to reduce component re-renders between key strokes and also try to memoize as much as possible. As far as I know there is no much room to improve regarding includes function performance (unless you're thinking in adding some external library) so I left it as is.

Please take this just like a suggestion and let me know if it is a good start point.

PSA: I had to add @material-ui/core, application doesn't start without it