GuillaumeFalourd / pull-request-action

Github Actions to create pull request (all os supported) using Github CLI โคต๏ธ
https://github.com/marketplace/actions/pull-request-action-github-cli
Apache License 2.0
3 stars 1 forks source link

upgrade nodejs deprecations #11

Closed stevie- closed 8 months ago

stevie- commented 8 months ago

hi, here is our take of your action.

you may want to adapt some things in your action.

GuillaumeFalourd commented 8 months ago

Hi @stevie- , thank you for contributing to the pull-request-action repository!

Updates related to the action.yaml file looks good to me. However, I wouldn't update the 3 workflows to test the action in each runner, neither the README.md file.

Would you mind If I just update the action using the action.yaml file implementation you suggested? ๐Ÿ˜ƒ

stevie- commented 8 months ago

Here is another version which is more close to the original code including bug fixes like handling multi line inputs https://github.com/datadrivers/pull-request-action/releases/tag/v2.1.3

GuillaumeFalourd commented 8 months ago

Here is another version which is more close to the original code including bug fixes like handling multi line inputs https://github.com/datadrivers/pull-request-action/releases/tag/v2.1.3

Thanks! I've created a test branch using exactly the action.yaml file implementation you suggested.

If you prefer updating this PR to push just this action.yml file to the repository, you'll appear as contributor ๐Ÿ‘๐Ÿผ

stevie- commented 8 months ago

your branch looks good