Closed GuillaumeGomez closed 2 years ago
Thanks for the crate, it works great!
I just hit this issue. Nothing major, but took me a while to find it after staring at the code for so long...
I have the following:
if (!/\/(contact|legal)\//.test(window.location) && !consented) {
This kept returning a Javascript error even though it worked fine in the browser console. Turns out that minifier::js thinks \// is a comment.
\//
Easy hack is to just append a .* to separate the double slash... just thought you may be interested to know of this case.
It is indeed. I'll try to fix it as soon as possible.
No stress, take your time.
Actually I'll reopen it because I still didn't add all tests. ^^'
Thank you!
Thanks for the crate, it works great!
I just hit this issue. Nothing major, but took me a while to find it after staring at the code for so long...
I have the following:
This kept returning a Javascript error even though it worked fine in the browser console. Turns out that minifier::js thinks
\//
is a comment.Easy hack is to just append a .* to separate the double slash... just thought you may be interested to know of this case.