search

GuillaumeGomez / minifier-rs

Minifier tool/lib for JS/CSS/JSON files
MIT License
86 stars 16 forks source link

Use std TryFrom trait #65

Closed djc closed 3 years ago

djc commented 3 years ago

In https://github.com/rust-lang/rust/pull/82781, I'm trying to experiment what we might run into if TryFrom/TryInto/FromIterator are added to the prelude. It turns out the compiler build itself fails because method calls in minifier become ambiguous. At some point we will have cargo fix lints to make this easier, but for now doing this manually was easy enough.

Would be nice to get a new release out so that the compiler can pick that up.

GuillaumeGomez commented 3 years ago

It just reminds me how old this project is everytime haha. Thanks for the PR!

GuillaumeGomez commented 3 years ago

I published your change.

djc commented 3 years ago

I saw, thanks for the quick response!