Multiroot bindings - Githubissues

GuillaumeGomez / rust-GSL

A GSL (the GNU Scientific Library) binding for Rust

189 stars 48 forks source link

Multiroot bindings #116

Closed catompkins closed 3 years ago

catompkins commented 3 years ago

Added bindings for multiroot solvers.

this required an update to regen.rs which caused subsequent changes to auto.rs. I used rust 1.54 + GSL v2.7 release.
the current auto.rs file required updates to matrix.rs and vector.rs due to mismatched type errors. You noted that there was a bug there previously w/ inconsistent types. It doesn't appear to be there at the moment.

GuillaumeGomez commented 3 years ago

So, after seeing your PR, I decided it was time to clean things up. So in the end, I modified the sys generator to take the 2.7 release directly, fixed some C header issues, added a checker for a few things. You can see all these changes in https://github.com/GuillaumeGomez/rust-GSL/pull/118.

Sorry to come a bit ouf of the blue like but could you rebase on master please? Normally the diff should be much smaller now without the sys changes. Thanks for your contribution in any case!

catompkins commented 3 years ago

So, after seeing your PR, I decided it was time to clean things up. So in the end, I modified the sys generator to take the 2.7 release directly, fixed some C header issues, added a checker for a few things. You can see all these changes in #118.

Sorry to come a bit ouf of the blue like but could you rebase on master please? Normally the diff should be much smaller now without the sys changes. Thanks for your contribution in any case!

Rebased on master + updated auto.rs from regen.

GuillaumeGomez commented 3 years ago

Just one remaining nit and it's good to go. This is great, thanks a lot! Please fix it then rebase on top master. Once this PR is merged, I'll make a new release.

GuillaumeGomez commented 3 years ago

I think you messed up your git history (why is there still 3b4c6e4 for example). :laughing: Please clean it up then I'll make a last review.

catompkins commented 3 years ago

I think you messed up your git history (why is there still 3b4c6e4 for example). 😆 Please clean it up then I'll make a last review.

Hmm, I think that particular commit was when I merged in some of your inline edits... Anyway, I just squashed all the commits. Should be good now.

GuillaumeGomez commented 3 years ago

Thanks!