GuillaumeGomez / sysinfo

Cross-platform library to fetch system information
MIT License
2.02k stars 302 forks source link

Improve support for NetBSD #631

Open 0323pin opened 2 years ago

0323pin commented 2 years ago

As expressed in #625, would it be possible to improve support for NetBSD?

I'm willing to help as much as possible to get this rolling.

Cheers!

GuillaumeGomez commented 2 years ago

It is possible, just that it'll take time. The first step will be to have a NetBSD CI set up.

0323pin commented 2 years ago

@GuillaumeGomez Just so it doesn't fall into oblivion, I'm trying to get some help with this.

0323pin commented 2 years ago

@GuillaumeGomez Long time, I know. I might have found something that could work, https://github.com/vmactions/netbsd-vm

What do you say?

GuillaumeGomez commented 2 years ago

It'd be very slow to run because it is a VM inside a VM. I did the same for freebsd at first and I stopped when it broke for a few months and switched to cirrus ci. Much faster without one VM layer.

0323pin commented 2 years ago

😢 ok, I get that. I know another dev reached out to cirrus ci to ask, I'll need to check with him if he got some answer back.

GuillaumeGomez commented 2 years ago

Thanks for asking around!

0323pin commented 2 years ago

@GuillaumeGomez I've just asked myself on this issue, https://github.com/cirruslabs/cirrus-ci-docs/issues/970

0323pin commented 1 year ago

@GuillaumeGomez Is this approach any better? https://github.com/asmjit/asmjit/commit/7421dea76455787c08317950a32f6cb4fd4bb175

I'll keep looking.

Also, elvish provides pre-compiled binaries, maybe worthy to dig into how these are compiled.

GuillaumeGomez commented 1 year ago

It's the same I originally used for freebsd a while ago which I then discarded because of the number of bugs and the slowness.

0323pin commented 1 year ago

I see :(

Thanks anyway.

0323pin commented 1 year ago

@GuillaumeGomez Maybe now it's possible. Apparently, both NetBSD and OpenBSD have been added to cirrus-ci, https://cirrus-ci.com/build/6221284932583424

Are you still willing to do this? Let me know if I can help somehow.

Regards

GuillaumeGomez commented 1 year ago

Oh nice! I should really speed up my current code rework so development can resume... In any case, you can always try to add support for one. I expect that NetBSD/OpenBSD will be more or less the same as FreeBSD.

0323pin commented 1 year ago

@GuillaumeGomez I'm on holidays until the 1st of August but, I'll look into it when I'm back home 👍

I don't really have enough knowledge to implement support on my own but, I'll try to go through the FreeBSD implementation and find my way around 😄 At least, I have a native environment. I'm planning on a fresh install to solve some bugs that have been annoying me for a while but, I should be able to start looking into this by the end of next week.

GuillaumeGomez commented 1 year ago

No hurry. I think taking a look is a good idea but I really need to finish the rework so you can work without problem. ^^'

0323pin commented 11 months ago

Some improvement. Not enough, I know. I'll try to keep adding stuff when I bump into it.