search

GuillaumeJasmin / react-table-sticky

Sticky hook for react-table v7
MIT License
189 stars 21 forks source link

Allow headergroups having depth more than 1. Fixes #12 #13

Closed hardikmodha closed 4 years ago

hardikmodha commented 4 years ago

Fixes #12.

Codesandbox: https://codesandbox.io/s/react-table-sticky-official-bkx1o?file=/src/App.js

It has both the examples

  1. Where column depth more than 1
  2. Where column depth is === 1
hardikmodha commented 4 years ago

@GuillaumeJasmin Please take a look. Let me know if I need to add some tests around it.

hardikmodha commented 4 years ago

@GuillaumeJasmin Friendly ping.

GuillaumeJasmin commented 4 years ago

Hi @hardikmodha Thanks for your contribution, sorry for late ! Your codesandbox doesn't work for me: horizontal scroll doesn't work. Could you add a second table demo in the demo/index.tsx please ? Thank you 🙂

hardikmodha commented 4 years ago

@GuillaumeJasmin

Your codesandbox doesn't work for me: horizontal scroll doesn't work.

Is it because of my changes or something else? I think it shouldn't affect, the changes are working fine with my app.

Could you add a second table demo in the demo/index.tsx please ?

I just need to replace the column definitions only. Right?

hardikmodha commented 4 years ago

@GuillaumeJasmin I've updated the demo. Horizontal scroll is also working fine in this. Let me know if you need anything else on this.

GuillaumeJasmin commented 4 years ago

Thank you for this PR Fix is available as of v1.1.3