search

GuillaumeLeclerc / vue-google-maps

Google maps component for vue with 2-way data binding
560 stars 653 forks source link

Please update to Vue 2.0 and stuff #119

Closed reisnobre closed 3 years ago

reisnobre commented 7 years ago

Only this bro, Please, update <3

xkjyeah commented 7 years ago

Sorry for the self-plug, but try vue2-google-maps

GuillaumeLeclerc commented 7 years ago

Would you want write access to merge it here ? , I have not tried vue2 yet.

xkjyeah commented 7 years ago

That would be good. Since your repository has all the stars the vue 2 version can now go on the CDN

On 8 Jan 2017 4:25 p.m., "Guillaume Leclerc" notifications@github.com wrote:

Would you want write access to merge it here ? , I have not tried vue2 yet.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GuillaumeLeclerc/vue-google-maps/issues/119#issuecomment-271137684, or mute the thread https://github.com/notifications/unsubscribe-auth/ACiTRyRgbUi5YzEXsj6FfaN0i1B9yjrBks5rQJ14gaJpZM4LPj-8 .

GuillaumeLeclerc commented 7 years ago

Is your version backward compatible ?

Envoyé depuis mon smartphone Samsung Galaxy. -------- Message d'origine --------De : Daniel Sim notifications@github.com Date : 08.01.17 14:44 (GMT+01:00) À : GuillaumeLeclerc/vue-google-maps vue-google-maps@noreply.github.com Cc : Guillaume Leclerc guillaume.leclerc.work@gmail.com, Comment comment@noreply.github.com Objet : Re: [GuillaumeLeclerc/vue-google-maps] Please update to Vue 2.0 and stuff (#119) That would be good. Since your repository has all the stars the vue 2

version can now go on the CDN

On 8 Jan 2017 4:25 p.m., "Guillaume Leclerc" notifications@github.com

wrote:

Would you want write access to merge it here ? , I have not tried vue2 yet.

—

You are receiving this because you commented.

Reply to this email directly, view it on GitHub

https://github.com/GuillaumeLeclerc/vue-google-maps/issues/119#issuecomment-271137684,

or mute the thread

https://github.com/notifications/unsubscribe-auth/ACiTRyRgbUi5YzEXsj6FfaN0i1B9yjrBks5rQJ14gaJpZM4LPj-8

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/GuillaumeLeclerc/vue-google-maps","title":"GuillaumeLeclerc/vue-google-maps","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/GuillaumeLeclerc/vue-google-maps"}},"updates":{"snippets":[{"icon":"PERSON","message":"@xkjyeah in #119: That would be good. Since your repository has all the stars the vue 2\nversion can now go on the CDN\n\nOn 8 Jan 2017 4:25 p.m., \"Guillaume Leclerc\" \u003cnotifications@github.com\u003e\nwrote:\n\n\u003e Would you want write access to merge it here ? , I have not tried vue2 yet.\n\u003e\n\u003e —\n\u003e You are receiving this because you commented.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/GuillaumeLeclerc/vue-google-maps/issues/119#issuecomment-271137684\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ACiTRyRgbUi5YzEXsj6FfaN0i1B9yjrBks5rQJ14gaJpZM4LPj-8\u003e\n\u003e .\n\u003e\n"}],"action":{"name":"View Issue","url":"https://github.com/GuillaumeLeclerc/vue-google-maps/issues/119#issuecomment-271152038"}}}

xkjyeah commented 7 years ago

Unfortunately, no. Vue 2 does not have two way binding or events, so it involved quite an extensive rewrite

On 8 Jan 2017 22:39, "Guillaume Leclerc" notifications@github.com wrote:

Is your version backward compatible ?

Envoyé depuis mon smartphone Samsung Galaxy. -------- Message d'origine --------De : Daniel Sim < notifications@github.com> Date : 08.01.17 14:44 (GMT+01:00) À : GuillaumeLeclerc/vue-google-maps vue-google-maps@noreply.github.com Cc : Guillaume Leclerc guillaume.leclerc.work@gmail.com, Comment < comment@noreply.github.com> Objet : Re: [GuillaumeLeclerc/vue-google-maps] Please update to Vue 2.0 and stuff (#119) That would be good. Since your repository has all the stars the vue 2

version can now go on the CDN

On 8 Jan 2017 4:25 p.m., "Guillaume Leclerc" notifications@github.com

wrote:

Would you want write access to merge it here ? , I have not tried vue2 yet.

—

You are receiving this because you commented.

Reply to this email directly, view it on GitHub

https://github.com/GuillaumeLeclerc/vue-google- maps/issues/119#issuecomment-271137684,

or mute the thread

https://github.com/notifications/unsubscribe-auth/ ACiTRyRgbUi5YzEXsj6FfaN0i1B9yjrBks5rQJ14gaJpZM4LPj-8

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":" 05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity": {"external_key":"github/GuillaumeLeclerc/vue-google-maps","title":" GuillaumeLeclerc/vue-google-maps","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/ 143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png"," avatar_image_url":"https://cloud.githubusercontent.com/ assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png ","action":{"name":"Open in GitHub","url":"https://github. com/GuillaumeLeclerc/vue-google-maps"}},"updates":{" snippets":[{"icon":"PERSON","message":"@xkjyeah in #119: That would be good. Since your repository has all the stars the vue 2\nversion can now go on the CDN\n\nOn 8 Jan 2017 4:25 p.m., \"Guillaume Leclerc\" \ u003cnotifications@github.com\u003e\nwrote:\n\n\u003e Would you want write access to merge it here ? , I have not tried vue2 yet.\n\u003e\n\u003e —\n\u003e You are receiving this because you commented.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/GuillaumeLeclerc/vue-google- maps/issues/119#issuecomment-271137684\u003e,\n\u003e http://github.com/GuillaumeLeclerc/vue-google-maps/issues/119#issuecomment-271137684%5Cu003e,%5Cn%5Cu003e or mute the thread\n\u003e \u003chttps://github.com/ notifications/unsubscribe-auth/ACiTRyRgbUi5YzEXsj6FfaN0i1B9yj rBks5rQJ14gaJpZM4LPj-8\u003e\n\u003e http://github.com/notifications/unsubscribe-auth/ACiTRyRgbUi5YzEXsj6FfaN0i1B9yjrBks5rQJ14gaJpZM4LPj-8%5Cu003e%5Cn%5Cu003e .\n\u003e\n"}],"action":{"name":"View Issue","url":"https://github. com/GuillaumeLeclerc/vue-google-maps/issues/119#issuecomment-271152038"}}}

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GuillaumeLeclerc/vue-google-maps/issues/119#issuecomment-271155052, or mute the thread https://github.com/notifications/unsubscribe-auth/ACiTR4dkDr3kC-MVg02_IUlVHwfg81zRks5rQPUggaJpZM4LPj-8 .

reisnobre commented 7 years ago

I end up using just a loader to expose the google object, but I'll look at your project @xkjyeah