search

GuillaumeSalles / redux.NET

Redux.NET is a predictable state container for .NET apps. Inspired by https://github.com/reactjs/redux.
712 stars 86 forks source link

extract delegates, IStore and add simple explanations #54

Closed lilasquared closed 7 years ago

lilasquared commented 7 years ago

I added some simple documentation to the public members based on what i saw here https://github.com/cmeeren/yarni/tree/master/src/Yarni.

this should be acceptable to close https://github.com/GuillaumeSalles/redux.NET/issues/31

GuillaumeSalles commented 7 years ago

Great! Thanks a lot for your work! It's really appreciated :)

I'm going to merge it as soon as the dynamic keyword is removed.

GuillaumeSalles commented 7 years ago

dynamic let you bypass compile time checks. If you cast an instance as dynamic, you will lose the type safety. https://msdn.microsoft.com/en-us/library/dd264736.aspx

If it's still not clear after the msdn article, feel free to ask me anything on dynamic.

lilasquared commented 7 years ago

No problem! This is my first time contributing to something open source so it's a learning experience for me as much as it is helpful for you. I will be working on the create store next and the enhancers but i want some more opinions on the enhancers.

GuillaumeSalles commented 7 years ago

I will answer to the v3 issue tonight or tomorrow. Maybe it will give some direction to make the enhancers.