Guillawme / rfret

Analyze FRET Binding Data with R
https://guillawme.github.io/rfret
Other
2 stars 5 forks source link

batch_process doesn't check filesystem paths #15

Closed Guillawme closed 7 years ago

Guillawme commented 7 years ago

The function batch_process doesn't check anything on the filesystem paths it works with. I am not sure how it performs when provided with an invalid path, or whether the current implementation is portable.

Guillawme commented 7 years ago

Example: if there is no trailing / at the end of the output directory name, output files are written in the current working directory instead and with the name of the output directory concatenated to all file names.

Files in input directory:

data001.csv
data002.csv

Wrong output directory name: outdir (correct one would be outdir/ with a trailing slash).

Output files are written in the current working directory, and with a wrong name:

outdirdata001_corrected.csv
outdirdata002_corrected.csv
Guillawme commented 7 years ago

Not relevant anymore.

The new pipeline data %>% format_data() %>% average_technical_replicates() %>% correct_fret_signal() handles any type of input. It still needs a function to write corrected output to a specified directory.