Closed Guillawme closed 7 years ago
After checking these two papers carefully, it turns out that correct_fret_signal()
is correctly implemented.
Fig. 11.4 in https://doi.org/10.1016/B978-0-12-391940-3.00011-1 is especially helpful to understand what are the correct calculations.
As of commit 4fe7ee01c32cb0a8809be7ebd174969469f08027, the signal correction uses an entire titration series of acceptor with buffer instead of other macromolecule. No need to change the code, but the documentation should emphasize that this blank experiment should be performed with unlabeled donor instead of buffer. This way, the acceptor direct excitation correction will also take into account any quenching effect of the acceptor dye by the other macromolecule.
On the other hand, the donor bleed through correction is calculated only with an average on 4 wells with donor-labeled macromolecule and buffer. The proper correction, to account for any quenching by the other macromolecule, should be performed with an entire titration series of unlabeled other macromolecule and constant amount of donor-labeled macromolecule. This not only requires updating the documentation, but also changing the code that calculates the donor bleed through correction.
This is also related to issue #21.
Fixed with commit f91b2e6020145ad41f58d95ca15f318c502cf28c.
I am not sure that the
correct_fret_signal()
function, as of commit 6d5d9453fcc0de31ba9fe6e4a4791527fc7cd892, works as it should.I should check how to exactly apply the correction. See following articles: