search

Guillemsc / GTweensGodot

C# tweening library for Godot 4.x
MIT License
180 stars 6 forks source link

Make the add-on available through NuGet #2

Closed mk56-spn closed 1 year ago

mk56-spn commented 1 year ago

First of all this looks amazing congratulations on your work so far!

Sorry if feature requests aren't welcome, the discussion tab isn't enabled so I figured opening an issue was my best bet.

The way godot does add-ons tends to pollute the user's folders especially when using any form of VCS . As such I think people would be grateful if offered a nuget package. I wouldn't mind attempting to make it myself if you have no interest.

Guillemsc commented 1 year ago

Hello! Thank you so much!

Feature requests are super welcome (I forgot to enable the discussion tab).

My initial idea was to have example scenes, which are bundled with the library itself. AFAIK this would be incompatible with NuGet, since it only can bundle code.

But, I think that having it as a NuGet package would bring many benefits, so my next steps will be to separate the examples into a different repo. This way installation is easier, and I can create a NuGet package more easily.

Guillemsc commented 1 year ago

I managed to create a nuget package without any issue. The problem is that I relied on the Autoload Godot functionality for automatically create the node that updates all tweens. The issue is that I can't reference scripts from a NuGet package for Autoload.

mk56-spn commented 1 year ago

Thats a good point, hmm not sure how this could be addressed. perhaps a stop gap solution would be adding some documentation that tells users to call a method that adds that autoload from their main scene, not ideal but it sounds workable no?

Guillemsc commented 1 year ago

I've added this installation section for now, which explains the workaround to make it work. I'll see how it can be improved it in the future. Let me know if it works for you :)

mk56-spn commented 1 year ago

I've added this installation section for now, which explains the workaround to make it work. I'll see how it can be improved it in the future. Let me know if it works for you :)

will test in a bit! how would you wish to be credited in the project i'm planning to use it in? aside from the MIT copy paste ofc. for stuff like credits ...

Guillemsc commented 1 year ago

Thanks, no hurries! There is no need for credit! But if you still feel like it, Guillem SC is fine :)

mk56-spn commented 1 year ago

Works as expected! far better than the native tween system on most fronts.

Guillemsc commented 1 year ago

Cool cool, closing this then 👍