Guimove / terraform-aws-bastion

Terraform module which creates SSH bastion infrastructure on AWS
https://registry.terraform.io/modules/Guimove/bastion/aws
Apache License 2.0
205 stars 184 forks source link

Add IMDSV2 Support #147

Closed Tohmua closed 1 year ago

Tohmua commented 1 year ago

Adds Support For IMDSV2

Fixed issue #146

Add support for the Instance Metadata Service V2 as using version 1 of the Instance Metadata Service is prone to publicly known weaknesses.

siourdas-vasilis commented 1 year ago

Hello @Tohmua can you add also the rest of the variables of the metadata_options like this PR https://github.com/Guimove/terraform-aws-bastion/pull/148 ? ( Excuse my PR I did not see yours before )

Tohmua commented 1 year ago

Hello @Tohmua can you add also the rest of the variables of the metadata_options like this PR #148 ? ( Excuse my PR I did not see yours before )

Yea ofc, sorry missed this. Ill update this tonight :)

Tohmua commented 1 year ago

Hey @siourdas-vasilis I added the extra options to my PR.

I preferred your approach of grouping them as a single variable / object rather than keeping them all as sepoarte variables... however I left it like this for consistency with how the rest of the project is structured.

Maybe @Guimove can comment on how they would prefer this to be structured as the owner :)

siourdas-vasilis commented 1 year ago

@Guimove pinging this.

TomBerriot commented 1 year ago

Hello :) We would also want to be able to customize metadata options for security reasons :eyes: Could we help in anyway make this PR go forward ? :pray: @Guimove

hamsec-aumni commented 1 year ago

Same goes for us.