search

GuitarML / GuitarLSTM

Deep learning models for guitar amp/pedal emulation using LSTM with Keras.
https://guitarml.com/
GNU General Public License v3.0
371 stars 47 forks source link

Prepare data with tensorflow? #5

Open mishushakov opened 3 years ago

mishushakov commented 3 years ago

currently numpy is used for preparing data in predict.py (and other places) it would makes sense to switch to corresponding methods in tensorflow

primary motivation would be better performance (source) and secondary, to have same preparation pipeline on every platform tensorflow supports, compared to numpy, which is only available in python

mishushakov commented 3 years ago

in my case particularly i have a problem translating some functions to javascript for example take a look at this

https://github.com/GuitarML/GuitarLSTM/blob/3c1dc9e379241c0f43369f2e60e88ffa0653df94/predict.py#L57

as far as i understand you're adding two arrays of different shapes by adding another dimension to one of them i'm in a big trouble now, 'cause i'm too dumb to reimplement the math myself and existing solutions don't work

having the task implemented in tensorflow would allow me to use your code as reference and reimplement the process using the very same methods available via TensorFlow.js API

GuitarML commented 3 years ago

@mishushakov I'm for that, I'll look into making it all tensorflow operations. Yes, when preparing the input data, each output audio sample depends on the previous "input_size" number of samples. So it's building an array of (numSamples, input_size,). For an input size of 100, 99% of the data is redundant, so I'm also interested in a more clever way of handling the preprocessing so that the RAM doesn't blow up.