Gum-Joe / 2Keys

A easy to setup second keyboard, designed for everyone.

GNU General Public License v3.0

11 stars 4 forks source link

V1 #72

Open Gum-Joe opened 4 years ago

Gum-Joe commented 4 years ago

V1 is a major change to 2Keys The plan is to use it to add modularity to 2Keys, so different detectors and executors can be used. This PR is the PR for V1.

codecov[bot] commented 4 years ago

Codecov Report

Merging #72 (eca2c3b) into master (245fa11) will increase coverage by 7.93%. The diff coverage is 87.11%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   79.17%   87.11%   +7.93%     
==========================================
  Files           9       10       +1     
  Lines         341      163     -178     
  Branches       39       10      -29     
==========================================
- Hits          270      142     -128     
+ Misses         54       21      -33     
+ Partials       17        0      -17

Impacted Files	Coverage Δ
detectors/detector-desktop/controller/src/index.ts	`0.00% <0.00%> (ø)`
...ktop/controller/src/setup/client/generateConfig.ts	`0.00% <0.00%> (ø)`
...tectors/detector-desktop/controller/src/install.ts	`69.23% <69.23%> (ø)`
...detector-desktop/controller/src/setup/client/vm.ts	`93.75% <93.75%> (ø)`
...ctors/detector-desktop/controller/src/constants.ts	`100.00% <100.00%> (ø)`
...tors/detector-desktop/controller/src/errorCodes.ts	`100.00% <100.00%> (ø)`
...r-desktop/controller/src/setup/client/newClient.ts	`100.00% <100.00%> (ø)`
...troller/src/setup/client/template-updates/index.ts	`100.00% <100.00%> (ø)`
...roller/src/setup/client/template-updates/launch.ts	`100.00% <100.00%> (ø)`
...oller/src/setup/client/template-updates/vagrant.ts	`100.00% <100.00%> (ø)`
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 245fa11...eca2c3b. Read the comment docs.

lgtm-com[bot] commented 4 years ago

This pull request introduces 11 alerts and fixes 12 when merging 4a0da88e15fb0ecaaad99828ef9361f7610b7366 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

10 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 11 alerts and fixes 12 when merging 923e0e397481d745421c4eecd682b01e25f18b59 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

10 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 11 alerts and fixes 12 when merging 6a68e2198ebc3a8eba68a34228190883fe1d93e5 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

10 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 11 alerts and fixes 12 when merging ad044fc1c58a98d97cd2930e61e840aa6c4630e9 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

10 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 11 alerts and fixes 12 when merging 028eeccb267739f702444ac64f380135a14cb184 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

10 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 11 alerts and fixes 12 when merging a9ebc6cefaa794696eafb9fe9fcb3a6c20e077e6 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

10 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 14 alerts and fixes 12 when merging 4ac82378482d76d7bdc5365ca54df713344bfe7b into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

13 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 14 alerts and fixes 12 when merging baf1aad7696ae0541701680d4591389500991cc2 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

13 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 14 alerts and fixes 12 when merging ab590abbed273a4fecfb888e6532f98c083c2729 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

13 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 14 alerts and fixes 12 when merging 6c02b6c13f78d0eab28172551a48cacdab3808c8 into d37a5a610530577a4fbf1076ddee0c97f04e291d - view on LGTM.com

new alerts:

13 for Unused variable, import, function or class
1 for Template syntax in string literal

fixed alerts:

12 for Unused variable, import, function or class