Gum-Joe commented 4 years ago

See ClickUp task for a full list of changes. This PR contains refactors to @twokeys/addons (mainly) as well more general refactors, in preparation for milestone 0 and the start of developing the OOBE code.

NB: default commit is a squash and merge, DO NOT DO THIS - use a regular merge commit instead

Gum-Joe commented 4 years ago

Task linked: CU-5wt3zd Registry and software refactorings

codecov[bot] commented 4 years ago

Codecov Report

Merging #84 into v1 will increase coverage by 3.46%. The diff coverage is 97.87%.

@@            Coverage Diff             @@
##               v1      #84      +/-   ##
==========================================
+ Coverage   91.32%   94.79%   +3.46%     
==========================================
  Files          38       39       +1     
  Lines        1407     1344      -63     
  Branches      222      209      -13     
==========================================
- Hits         1285     1274      -11     
+ Misses        122       70      -52

Impacted Files	Coverage Δ
...ackages/@twokeys/addons/src/util/zip-downloader.ts	`100.00% <ø> (+20.83%)`	:arrow_up:
...twokeys/server/src/oobe/software/zip-downloader.ts	`100.00% <ø> (+16.12%)`	:arrow_up:
packages/@twokeys/addons/src/registry.ts	`90.55% <96.29%> (+3.92%)`	:arrow_up:
packages/@twokeys/addons/src/dev-tools.ts	`100.00% <100.00%> (+57.14%)`	:arrow_up:
...s/@twokeys/addons/src/module-interfaces/twokeys.ts	`100.00% <100.00%> (ø)`
...ges/@twokeys/addons/src/software-query-provider.ts	`96.70% <100.00%> (-0.24%)`	:arrow_down:
packages/@twokeys/addons/src/software.ts	`99.01% <100.00%> (ø)`
packages/@twokeys/addons/src/util/constants.ts	`100.00% <100.00%> (ø)`
packages/@twokeys/addons/src/util/copy-contents.ts	`91.86% <100.00%> (+1.27%)`	:arrow_up:
packages/@twokeys/addons/src/util/downloader.ts	`94.73% <100.00%> (+17.65%)`	:arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 976d96f...d5de384. Read the comment docs.