Closed Gum-Joe closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
v1@c517606
). Click here to learn what that means. The diff coverage is85.42%
.
@@ Coverage Diff @@
## v1 #92 +/- ##
=====================================
Coverage ? 91.49%
=====================================
Files ? 64
Lines ? 1845
Branches ? 247
=====================================
Hits ? 1688
Misses ? 157
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
executors/@twokeys/executor-ahk/src/constants.ts | 100.00% <ø> (ø) |
|
packages/@twokeys/addons/src/software.ts | 99.01% <ø> (ø) |
|
...twokeys/common-hi/src/setup/commands/new-client.ts | 0.00% <0.00%> (ø) |
|
packages/@twokeys/core/src/interfaces.ts | 100.00% <ø> (ø) |
|
packages/@twokeys/native-utils/src/index.ts | 0.00% <0.00%> (ø) |
|
...twokeys/server/src/oobe/software/zip-downloader.ts | 100.00% <ø> (ø) |
|
packages/@twokeys/core/src/config.ts | 51.28% <30.76%> (ø) |
|
...keys/addons/src/module-interfaces/twokeys-utils.ts | 34.78% <34.78%> (ø) |
|
packages/@twokeys/addons/src/registry.ts | 89.64% <91.66%> (ø) |
|
...detector-desktop/controller/src/setup/client/vm.ts | 93.75% <93.75%> (ø) |
|
... and 77 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c517606...d867e1c. Read the comment docs.
This PR adds the required code for setting up a new client in the
@twokeys/detector-desktop
controller add-on.It also adds tests for this, as well as addition
twokeys
object APIs that the controller needs.New APIs:
twokeys.utils
: A set of utilities to make add-on code easier:twokeys.utils.addToStartup
& related functions: Adds a script to startup with a predictable name, so add-on devs don't have to manually do this.config.write
: Part of any config object returned by config loaders in@twokeys/core/src/config.ts
(currently onlyloadClientConfig
), which allows certain parts of the config to be written to (in the case ofloadClientConfig
, only theconfig.controllerConfig
is writable (as controller add-ons should put all related config in that property)