search

GumTreeDiff / gumtree

An awesome code differencing tool
https://github.com/GumTreeDiff/gumtree/wiki
GNU Lesser General Public License v3.0
893 stars 170 forks source link

Diff class support for Resources #289

Closed rpau closed 1 year ago

rpau commented 1 year ago

This commit is adding a new compute method to support the diff processing of resources instead of paths.

This functionality is intersting when the files that need to be computed are not in the local file and are downloaded from the Internet using APIs in memory.

jrfaller commented 1 year ago

Hi and thanks a lot for the PR!

It seems that there are a couple of formatting issues, but otherwise seems good!

Can you fix the formatting issues?

Cheers!

rpau commented 1 year ago

Sure, Now I'll review the issues reported during the build. Sorry for that.

rpau commented 1 year ago

@jrfaller I need again your approval to run the workflow. Sorry, hopefully this is the good one :)

rpau commented 1 year ago

@jrfaller Hopefully now the test error is fixed :)

rpau commented 1 year ago

@jrfaller Can you merge it now? :)

jrfaller commented 1 year ago

@rpau done! Thanks for cleaning-up the PR!