search

GumTreeDiff / gumtree

An awesome code differencing tool
https://github.com/GumTreeDiff/gumtree/wiki
GNU Lesser General Public License v3.0
933 stars 174 forks source link

feat: add tree-sitter-ng for tree generator. #345

Closed XYZboom closed 6 months ago

XYZboom commented 7 months ago

tree-sitter-ng is a java binding of tree-sitter, so with tree-sitter-ng, we don't need python anymore and we can generate tree in memory instead of reading xml from disk.

jrfaller commented 7 months ago

Hi, and thanks a lot for this amazing PR! I was not aware of tree-sitter-ng and it seems far more convenient than the previous java binding I looked at and than our current use of Python. I have reviewed your code and only has a few comments. I have yet to compile and try it to see if the deployment is easy.

XYZboom commented 7 months ago

fix a bug and add some unit tests for this fix.

jrfaller commented 7 months ago

Hi! Thanks a lot for the bugfix. Did you get the chance to look at my comments? Cheers!

XYZboom commented 7 months ago

Sorry, I can't seem to see your comments. Can you help me find it, thanks!

XYZboom commented 7 months ago

I have already checked the option to open comments, but the interface hasn't changed. image

jrfaller commented 7 months ago

Sorry @XYZboom I was thinking you were seeing them 😢 . I assigned you to the PR and clicked on a menu to finish the review to ask for changes. Do you see them now? Cheers!

XYZboom commented 7 months ago

Sorry @XYZboom I was thinking you were seeing them 😢 . I assigned you to the PR and clicked on a menu to finish the review to ask for changes. Do you see them now? Cheers!

Thank you, I can now see these comments!