Upgrade modular-scale to version 2.0.5

GumbyFramework / Gumby

A Flexible, Responsive CSS Framework - Powered by Sass

http://gumbyframework.com/

2.85k stars 440 forks source link

Upgrade modular-scale to version 2.0.5 #221

Closed keegan-lillo closed 9 years ago

keegan-lillo commented 10 years ago

modular-scale 1.0.6 really doesn't play nicely with compass 1.0 and sass 3.3. modular-scale 2.0.5 works fine with a few modifications and caveats:

Caveat: Rounding to whole pixels is no longer supported. We could do this manually with an extra function wrapper but I have not implemented such a thing in this pull request.

I have tested with:

compass v0.12.6 + sass v3.2.19
compass v1.0.0.alpha.19 + sass v3.3.7

danhere commented 9 years ago

@keegan-lillo, I ended up having to do this manually on my end because your pull request was getting rejected for me. If you pull down the latest, ms should be updated. If there's anything I missed, let me know.