GumbyFramework / Gumby

A Flexible, Responsive CSS Framework - Powered by Sass
http://gumbyframework.com/
2.85k stars 440 forks source link

Misleading installation instructions! Modular-Scale Version Issue! #236

Open parthsha opened 10 years ago

parthsha commented 10 years ago

I spent the last 2.5 hours trying to setup Gumby. After a lot of headache, I am amazed that it even worked. Here is the culprit behind the entire problem!

On http://gumbyframework.com/docs/#!/gem-dependencies, instruction states to "gem install compass modular-scale sass". Why isn't it publicly stated that gumby has a dependency on v1.0.6 of modular-scale? Modify your instruction to "gem install modular-scale -v 1.0.6"! (Source: README.md. "- Modular Scale - Scott Kellum Note: Please use modular scale 1.0.6, 2.x has not been integrated yet")

I ran gem install modular-scale and it downloaded 2.0.5! Worse, when i did gem cleanup modular-scale, it didn't even delete that version. I had to manually go into the directory where all the gems were installed and delete that version. (On Windows, go to \lib\ruby\gems\2.0.0\gems to see all the gems that were installed on your machine. Please modify 2.0.0 with the version of Ruby you have installed on your machine. What a lousy url!)

I am an absolute beginner to SASS, so this entire installation as well as tutorials on how to use gumby/compass/sass was painful! Honestly the only motivation to continue with this whole thing was the screenshots of the features that were displayed.

jeffdran commented 10 years ago

I ran into this problem too. I was able to fix it to work with later versions by renaming variables in modular-scale.

https://www.dropbox.com/s/ek0mn2rhe1q8cw7/Screenshot%202014-08-21%2007.34.29.png

craigkeller commented 10 years ago

I just submitted a pull request to fix this. Once it is tested you will need to pull and upgrade your sass, compass, and modular scale to the latest versions.

parthsha commented 10 years ago

I really appreciate the move of the framework to use the latest version of modular scale. But honestly if someone in the Project team were to just change the instructions for installing modular scale, that too would be more than sufficient. I don't think it would matter to developers if the framework is targeting the latest version of modular scale or the v-1 to be honest.

ARolek commented 10 years ago

It would be nice to know exactly what versions of all the dependencies are needed for Gumby. I have been battling this setup for hours now too, and just figured out the modular scale install, but I'm still getting compile errors when running compass compile:

modular-scale.rb:123:in `delete_if': can't modify frozen Array)
contradictioned commented 10 years ago

Hey, another problem with 2.x incompatibility is, that modular-scale doesn't / didn't have 1.x tags in the github repository, and so bower (and related tools) cannot install these versions easily.

PS: If there is more work to do than this https://github.com/GumbyFramework/Gumby/pull/221 pull request, then please post it, I would be delighted to help :)

matalina commented 10 years ago

To fix: modular-scale.rb:123:indelete_if': can't modify frozen Array)` you have to us compass 0.12.2