search

GumbyFramework / Gumby

A Flexible, Responsive CSS Framework - Powered by Sass
http://gumbyframework.com/
2.85k stars 442 forks source link

update modular scale #256

Closed unHuesio closed 9 years ago

unHuesio commented 9 years ago

Gumby needs to update its modular scale dependency to new version. Gumby can't be compile with latest compass/sass version because of incompatible units px and em.

After fixing this, people might now use gumby freely with bower and other frameworks such as ember-cli and broccoli-compass

tamarmot commented 9 years ago

agree, this would fix the problem I ran into trying to use django-pipeline-compass with gumby

scottkellum commented 9 years ago

I recently got an issue related to this on modular-scale: https://github.com/at-import/modular-scale/pull/85

Note that incompatible units px and em error is from Compass’ vertical rhythm module and Gumby must set the base size to a px value if it plans to use modular scale with Compass vertical rhythm regardless of what version is installed.

unHuesio commented 9 years ago

I upload an update a gumby version I saw somewhere, just make it available for other devs with similiar issues... http://bower.io/search/?q=gumby-ember

danhere commented 9 years ago

If you guys can update modular scale and create a pull request I will merge it in asap. Thanks!

danhere commented 9 years ago

Newest modular-scale is now in Gumby. Pull down the latest and you should be all set.