search

Gumichan01 / lmms-pkg

LMMS Project Packager
GNU General Public License v3.0
12 stars 0 forks source link

Bundle built-in samples #3

Closed Gumichan01 closed 3 years ago

Gumichan01 commented 3 years ago

From https://github.com/LMMS/lmms/issues/1257#issuecomment-452336007

built-in samples should be bundled because the future of LMMS is not guaranteed to contain the same exact built-in samples.

Difficulties:

The path to LMMS samples is not known, so the user has to provide it manually.
~I can reduce the burden by just letting the user provide the path to the LMMS directory (/path/to/lmms/) so I can get /path/to/lmms/data/samples and calculate /path/to/lmms_data/samples~ This soluton is platform dependent. The user has to provide information about where built-in samples are, because he/she must know where he/she installed the program.

This is not the best solution but it could do the job.

Gumichan01 commented 3 years ago

Including built-in samples must be done by providing the path to the samples directories in LMMS and LMMS data locations.

--lmms-dir "path/to/LMMS_Data/samples/" "path/to/LMMS/data/samples/"

You can specify multiples paths.

Commit 946800b fix this issue.