Closed theogiraudet closed 1 month ago
Everything looks fine, i'm just not convinced by the name. All other spawn functions are summoning a new entity which is not really the case here. Maybe something like emit_block_particles
would be more appropriate?
I agree, but the folder is named "spawn" :/
We can just move the function to an other folder. Also I think we should add a very simple test to just see if the run function is working (in case mojang change the particle command for example)
For me, renaming the folder to "produce" would be a better idea. But this is a breaking change… +1 for the test.
You can rename it it's not breaking change since functions are tagged and the internals are not supposed to be used directly. Im completly fine with this change
Oh this is true, my bad. Let's do that, this name is better for new features.
@aksiome I let you review the new version.
Tasks to do before merging
/docs
)