Gunivers / Bookshelf

📚 Bookshelf is a modular library datapack designed to simplify complex systems in Minecraft maps. Ideal for mapmakers looking for easy-to-implement tools.
http://bookshelf.docs.gunivers.net
Mozilla Public License 2.0
40 stars 13 forks source link

✨ Add `bs.block:emit_block_particles` #259

Closed theogiraudet closed 1 month ago

theogiraudet commented 1 month ago

Tasks to do before merging

aksiome commented 1 month ago

Everything looks fine, i'm just not convinced by the name. All other spawn functions are summoning a new entity which is not really the case here. Maybe something like emit_block_particles would be more appropriate?

theogiraudet commented 1 month ago

I agree, but the folder is named "spawn" :/

aksiome commented 1 month ago

We can just move the function to an other folder. Also I think we should add a very simple test to just see if the run function is working (in case mojang change the particle command for example)

theogiraudet commented 1 month ago

For me, renaming the folder to "produce" would be a better idea. But this is a breaking change… +1 for the test.

aksiome commented 1 month ago

You can rename it it's not breaking change since functions are tagged and the internals are not supposed to be used directly. Im completly fine with this change

theogiraudet commented 1 month ago

Oh this is true, my bad. Let's do that, this name is better for new features.

theogiraudet commented 1 month ago

@aksiome I let you review the new version.