Update things to comply with PEP8

Gunn-GAtM / gatm

A rewrite of A Geometric Approach to Matrices (GAtM) by Peter Herreshoff

https://gunn-gatm.github.io

12 stars 10 forks source link

Update things to comply with PEP8 #41

Closed ky28059 closed 3 years ago

ky28059 commented 3 years ago

@anematode should review this and tell me if anything breaks

ytchang05 commented 3 years ago

Will close temporarily and reopen in hopes that de-bugged PR workflow will trigger this time.

ytchang05 commented 3 years ago

Workflow, please run...

ky28059 commented 3 years ago

Some other recommendations I will make:

gen_answer_key.py is not used so you should delete (its archived in git history already and keeping it makes the repo bigger but also makes pycharm freak out about duplicated code)
unfinished code should probably not be committed (generate_matrix_mult.py trails off after an if, the comment in build.py abruptly stops)
less name shadowing so that its more apparent whats supposed to be a declaration and whats an assignment which has mistakenly become a declaration because of python 3

ytchang05 commented 3 years ago

What that workflow meant to say is:

The edits were built successfully! View the gatm-textbook artifact from this workflow here.

Turns out that a workflow run on a PR by someone w/o repo perms doesn't have comment perms either, so I will have to find a way to fix that in the future, however the built textbook artifact did upload.

anematode commented 3 years ago

I'll be honest, I don't remember how compare_books.py works at all. But I'll take a look at some point!

ky28059 commented 3 years ago

Merge conflicts are painful, please stop committing to main before reviewing and merging this PR @anematode!

ky28059 commented 3 years ago

Closing and reforking because new commits