GunnarFarneback / LocalRegistry.jl

Create and maintain local registries for Julia packages.
Other
223 stars 21 forks source link

make LocalRegistry work with the new breaking version of RegistryTools #64

Closed KristofferC closed 1 year ago

KristofferC commented 1 year ago

See https://github.com/JuliaRegistries/RegistryTools.jl/pull/78 for rationale.

KristofferC commented 1 year ago

Removed all the debug stuff, sorry abou that.

codecov-commenter commented 1 year ago

Codecov Report

Base: 96.66% // Head: 91.11% // Decreases project coverage by -5.55% :warning:

Coverage data is based on head (dc3c227) compared to base (f40fda9). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #64 +/- ## ========================================== - Coverage 96.66% 91.11% -5.56% ========================================== Files 1 1 Lines 270 270 ========================================== - Hits 261 246 -15 - Misses 9 24 +15 ``` | [Impacted Files](https://codecov.io/gh/GunnarFarneback/LocalRegistry.jl/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gunnar+Farneb%C3%A4ck) | Coverage Δ | | |---|---|---| | [src/LocalRegistry.jl](https://codecov.io/gh/GunnarFarneback/LocalRegistry.jl/pull/64/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gunnar+Farneb%C3%A4ck#diff-c3JjL0xvY2FsUmVnaXN0cnkuamw=) | `91.11% <100.00%> (-5.56%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gunnar+Farneb%C3%A4ck). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gunnar+Farneb%C3%A4ck)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

KristofferC commented 1 year ago

Ugh, do you think it is fine to drop julia 1.1?

GunnarFarneback commented 1 year ago

It's gonna be difficult to keep supporting Julia 1.1 when RegistryTools doesn't.

KristofferC commented 1 year ago

Well, we can make the code here compatible with both RegistryTools 1.9 and 2.0 (thereby supporting Julia 1.1 as well).

GunnarFarneback commented 1 year ago

That sounds exceedingly painful. Better give up on the pre-1.6 versions.

GunnarFarneback commented 1 year ago

Thanks.