search

Gunnerus / gunnerus

Python, Django, Bootstrap 3 and SQLite-based cruise reservation system
2 stars 1 forks source link

Let invoices be sent multiple times #420

Closed AudunVN closed 3 years ago

AudunVN commented 3 years ago

The system was not built to handle invoices being rejected after they had been sent out by the invoicer - we originally considered them the responsibility of the invoicer once they were accepted and sent out. As a result, the system currently marks invoices that have been sent as unchangeable.

We need an flow for the invoicer to mark invoices as unsent when they are rejected by the recipient, or only look at the values of the "isFinalised" and "isPaid" fields to determine whether the invoice can be changed by administrators. Latter is likely the best option unless it has unforeseen consequences.

AudunVN commented 3 years ago

Will send a mail to Terje and ask for what should be done for the currently stuck invoices - are all of them still unsent and unpaid?

AudunVN commented 3 years ago

Mail sent.

AudunVN commented 3 years ago

Only state that should be irreversible is the invoice having the isPaid field set to true. Verify that there is a modal shown for the invoicer asking for confirmation before placing the invoice in this state.

AudunVN commented 3 years ago

Resolved by 8fc70eb, live on production server. Invoices can be marked as unpaid.