Gunpowder-MC / GunpowderUtilities

MIT License
3 stars 0 forks source link

Incompatibility with Taterzens #17

Closed samolego closed 3 years ago

samolego commented 3 years ago

Hi there, I've been reported that Taterzens mod is incompatible with Gunpowder Utilities.

The problem is that PlayerListS2CPacketMixin_Utilities#skipVanished doesn't check if player is null before checking if it's vanished. (https://github.com/Gunpowder-MC/GunpowderUtilities/blob/af8551ccc352513ae10b16dd506abe62837fe50a/src/main/java/io/github/gunpowder/mixin/utilities/PlayerListS2CPacketMixin_Utilities.java#L53)

In case of Taterzen, PlayerListS2CPacket is a fake one, so there's no player behind the packet, thus it crashes in network thread (I assume it's NPE for above reasons). This is kinda my fault since if I remember correctly, that mixin was part of my vanish PR 😄 .

If you'd like, I can add a simple not null check in #6