Group OSCORE: Fix compile errors when WITH_GROUPCOM is not defined

Gunzter / contiki-ng

Contiki-NG: The Next Generation Contiki

BSD 3-Clause "New" or "Revised" License

7 stars 4 forks source link

Group OSCORE: Fix compile errors when WITH_GROUPCOM is not defined #11

Open MBradbury opened 3 years ago

MBradbury commented 3 years ago

Contiki-NG should compile when WITH_GROUPCOM is not defined, or code paths that are specified when WITH_GROUPCOM is not defined should be removed.

Ideally, there would be no difference between defining WITH_GROUPCOM or not defining WITH_GROUPCOM. It would be preferable if a user of the API could specify if they want encrypted+mac (OSCORE), encrypted+mac+digital signature (Group OSCORE) or digital signature (Group OSCORE).

MBradbury commented 3 years ago

Some examples, a parameter seems to be missing from get_src_endpoint at https://github.com/Gunzter/contiki-ng/blob/group_oscore/os/net/app-layer/coap/coap-uip.c#L390

verify_res will not be defined at https://github.com/Gunzter/contiki-ng/blob/group_oscore/os/net/app-layer/coap/coap-engine.c#L211 when WITH_GROUPCOM is not defined.