search

GuoAi / pe

0 stars 0 forks source link

Guaranteed error with bookmarks with 5 entries #19

Open GuoAi opened 4 years ago

GuoAi commented 4 years ago

Since the limit is 5 API requests per minute, if users execute one command before using bookmarks, it is guaranteed to get an API error when there are 5 entries in the bookmark.

image.png

nus-pe-bot commented 4 years ago

Team's Response

Most of our functions calls the API, and because of the API request limit, many of our functions will not work if there are too many calls to the API, we agree that this has made it difficult for users to use the app efficiently and has caused some of our functions to constantly display the API limit error especially when the function requires more than 5 calls made to the API to be ran. We have tried to include caveats (such as setting the bookmarks limit to 5) it will still require users to wait for awhile before being able to run any other command. We could only fix these issues if we pay for the premium price for fetching stock data from that API, which we have also stated in our user guide.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: Almost all the commands have the API limit reached problem. During testing, none of the features could work properly because the API limit is 5 per minute and sometimes a single command requires multiple APIs (one single bookmarks command may use 5 APIs). Since this app is intended for fast typists, this is definitely a severe problem. (Can you imagine a fast-typist types one command, then wait for 60 seconds and then type the 2nd command?) Since this has caused all the commands to malfunction, I think this is a FunctionalityBug with severity.High.

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: Almost all the commands have the API limit reached problem. During testing, none of the features could work properly because the API limit is 5 per minute and sometimes a single command requires multiple APIs (one single bookmarks command may use 5 APIs). Since this app is intended for fast typists, this is definitely a severe problem. (Can you imagine a fast-typist types one command, then wait for 60 seconds and then type the 2nd command?) Since this has caused all the commands to malfunction, I think this is a FunctionalityBug with severity.High.