question about the difference between matlab code and python code of isp process

GuoShi28 / CBDNet

Code for "Toward Convolutional Blind Denoising of Real Photographs", CVPR 2019

Apache License 2.0

501 stars 92 forks source link

question about the difference between matlab code and python code of isp process #33

Closed PeeBar closed 4 years ago

PeeBar commented 5 years ago

Thanks for provide the python code of isp process, I just find that you add Poisson-Gaussian noise before mosaic_bayer in the matlab code, but you add the noise after mosaicing and inver white balancing in the python code. Is this difference reasonable?

GuoShi28 commented 5 years ago

Mosaic can treat as linear pixel sampling. So adding noise before and after this step is the same for the final training data. Adding noise after mosaic_bayer is more explainable.

PeeBar commented 5 years ago

Thank you very much.

PeeBar commented 5 years ago

Hello! I am sorry to interrupt you again cause I find that there is a small difference between the CRF_Map.m file and the CRF_Map function in python. In the CRF_Map.m file, comp2=temp-B(index-1), but it becomes to temp-I_temp(index-1) in Python.Can you tell me which one is right? Thank you!

GuoShi28 commented 5 years ago

I check the code and find the python code may be right. I update the Matlab code. Thank you for pointing it out.

PeeBar commented 5 years ago

Thanks for your response!