search

Guribo / UdonVoiceUtils

Tools/Components for UDON (VRChat) based worlds. Includes private channels, reverb, auto player range adjustment, etc. for player voices.
https://guribo.github.io/TLP
MIT License
147 stars 4 forks source link

Script error when importing #25

Open Ranily57 opened 5 months ago

Ranily57 commented 5 months ago

image

I have several error when importing the package !

UVU Version : 1.0.0 UdonUtils Version : 8.1.1

An error example:

[<color=#FF00FF>UdonSharp</color>] Packages/tlp.udonvoiceutils/Runtime/Core/PlayerAudioOverride.cs(404,50): error CS1061: 'PlayerList' does not contain a definition for 'DiscardInvalid' and no accessible extension method 'DiscardInvalid' accepting a first argument of type 'PlayerList' could be found (are you missing a using directive or an assembly reference?)

Guribo commented 5 months ago

It looks like you installed it via Unitypackage, this is not the recommended way as you are now missing a bunch of dependencies.

Please follow the guide in the Readme: https://github.com/Guribo/UdonVoiceUtils?tab=readme-ov-file#getting-started

I tested it again to be sure with a clean project:

image image

(You can ignore UdonUiAnimators in these pictures, it is not needed for UVU)

Guribo commented 5 months ago

Maybe relevant, I think I remember seeing a similar issue after importing. It may be that some packages are not yet fully resolved by the Package Resolver. All I did was close the project and reopen it again. It would import some files and work just fine afterwards.

Please let me know if any of this helped.

Glynn-Taylor commented 4 months ago

Adding the package in VCC did not add the dependency Cyan's Player Pool for me, causing similar errors, so I had to manually add that and then relaunch the project.

Guribo commented 4 months ago

that is expected behaviour, it is described here: https://github.com/Guribo/UdonUtils?tab=readme-ov-file#installation

There is no way I know of to automatically add the cyan repository to VCC when adding my repository...

Glynn-Taylor commented 4 months ago

Ah that must be a frustrating limitation, the Readme.md for UdonVoiceUtils didn't mention it (unless I'm blind) so I thought it might resolve it automatically as I already had the player pool repo added. Maybe one day VRChat will bless us with that technology x)

Guribo commented 4 months ago

image It is in the readme ;)

Glynn-Taylor commented 4 months ago

Ah for some reason I presumed that meant just to have the repository added to VCC and it didn't matter if it was added to the project yet my mistake x)

Guribo commented 4 months ago

I will update this soon, too many people struggle with that so it is obvious that it isn't clear enough, no worries :D