search

GurinderRawala / server-permiles

nodejs/postgres/express
0 stars 0 forks source link

Pm 32 hash a user account password #8

Closed GurinderRawala closed 2 years ago

mannu635 commented 2 years ago

This is not using Dependency Injection and You are mutating the driver directly which is a bad programming practice. Instead, we will update Driver class so we can call const driver = new Driver(req.body) the class Driver will have the responsibility of hashing the password and providing all the other methods that are needed.

mannu635 commented 2 years ago

Closing this PR until the above mentioned comment gets implemented.

GurinderRawala commented 2 years ago

Ok I will change the code accordingly and commit again. Other then that adding bcrypt and hash-password file is good?